Carsten Müller

Carsten Müller

malison@hub.netzgemeinde.eu

This channel has not added a profile description yet

Ort:: Deutschland

Geschlecht:: Männlich

Tue, 14 May 2019 18:37:17 +0200

Carsten Müller

malison@hub.netzgemeinde.eu

!Hubzilla Support Forum
I got that link in a Diaspora Post shared from a Friendica Post: https://pirati.ca/posts/ec054ce7-115c-da81-529a-1a2384409933
But that ../posts/... part of that link should be /display/ not /posts/. The correct link https://pirati.ca/display/ec054ce7-115c-da81-529a-1a2384409933 works

Thats the Post: https://hub.netzgemeinde.eu/display/f2f77d205891013795380218b7b8dc7d
Thats the Code:

[share author='Marie+Sa' profile='https://pirati.ca/profile/mariesa' avatar='https://hub.netzgemeinde.eu/photo/9961b7ea9707d2be360b3fb00a0a6359-5' link='https://pirati.ca/posts/ec054ce7-115c-da81-529a-1a2384409933' auth='false' posted='2019-05-14 16:19:18' message_id='f2f77d205891013795380218b7b8dc7d'][/share]

Tue, 14 May 2019 22:47:27 +0200

El Dorado

mike@z.macgirvin.com

I think we typically use whatever is the permalink of the original post. This would indicate that the pubcrawl addon is probably using the post "id" and failing to test for an html 'url' element. I vaguely remember fixing this in Osada some time ago but it may not have been ported back to Hubzilla.

If that's the case one might compare Zotlabs/LibActivity.php and addon/pubcrawl/as.php where it parses incoming objects and copy/paste the newer code.

--

Eventually we should get rid of pubcrawl/as.php and use the more recent Activity library but I didn't do this because Mario (and others) added a lot of their own compatibility fixes to pubcrawl. The implementations need to be tediously compared to make sure there aren't regressions.

Perhaps the best place to start is to continue using as.php but slowly convert to Activity:: functions where it is easy and where there aren't many or any differences in the code. Then spend a bit more time researching the differences on the hard ones. This way it is more of a phased (and manageable) migration than a drop-in replacement which could really screw things up.